mjhjmtu

I am having a problem with this script

#!/bin/bash
echo “Enter option “
echo “1 PIC”
echo “2 ICON”
read $answer 
echo

if [[$answer == 1 ]] ; then 
rename 's/^.*([0-9]3.jpg)$/ICON$1/' *.jpg ;
echo “done” 

elif 
if [[$answer == 2 ]] ; then 
rename 's/^.*([0-9]3.jpg)$/PIC$1/' *.jpg ;
echo “done” 
else 
echo “Error”
fi
done 

I think you want this. The list of the problems in your original script would be longer than the script itself.

#!/bin/bash
echo "Enter option"
echo "1 PIC"
echo "2 ICON"
read answer 
echo

if [ "$answer" == 1 ]
then
 ext=ICON
elif [ "$answer" == 2 ]
then
 ext=PIC
else 
 echo "Error"
 exit 1
fi

ls|grep -i .jpg$|while read i
do
 mv -vf "$i" "$i%.*"."$ext"
done

echo "done"

To replace all but the last three digits and the filename suffix of all JPEG files in the current directory with either the word PIC or ICON, you may do the following (this interactively asks for the prefix to use):

#!/bin/bash

echo 'Please select prefix:' >&2

select prefix in 'ICON' 'PIC'; do
 case $REPLY in
 1) break ;;
 2) break ;;
 *) echo 'Try again' >&2
 esac
done

rename 's/.*([0-9][0-9][0-9].jpg)/'"$prefix"'$1/' *[0-9][0-9][0-9].jpg

echo 'Done' >&2

I've chosen to use select as this produces a nice looking menu of the available options. I'm also applying the rename command only to the files that I know can be renamed (there may be other JPEG files in the directory that does not have the three digits, for example). All output from this script is strictly user interaction, so I'm doing this on the standard error stream (with >&2).

The issues with your original script are

1. 
   [[ must be followed by a space.


2. Double quotes are "...", not “...”.


3. The read utility takes a variable name, not a value.


4. There is a dangling done at the end of the code.


5. 
   elif expects a test (not an if).

A suggestion would be to run you scripts through a syntax checker, such as the one available online at https://www.shellcheck.net/

Also, when asking questions like these, it is quite important to include the exact error message produced by the script, and also to mention what it is that you actually want to do (so that we don't have to reverse-engineer your code). See e.g. Jeff's excellent Meta question-and-answer about asking well received questions.