mjhjmtu

I am having trouble on a test that is setting a record type. I believe I am setting the record type the correct way, the test is passing, but my test coverage is telling me that no record type was set. How am I setting the record type incorrectly in the test?

static testMethod void test6()
 RecordType rt = [Select Id, Name From RecordType Where SobjectType = 'advpm__Matter__c' AND Name = 'Litigation'];
 Account a = new Account(Name = 'test');
 insert a;
 Opportunity o = new Opportunity(AccountId = a.Id, CloseDate = Date.today(), Name = 'test', StageName = 'Identified');
 insert o;
 Case c = new Case(Opportunity__c = o.Id, Status = 'Open');
 insert c;
 advpm__Matter__c matter = new advpm__Matter__c(RecordTypeId = rt.Id, Case__c = c.Id,Date_of_Default__c = null, Outstanding_Balance__c = null, Rush__c= true, Concurrent_Deal__c=true);

 Test.startTest();
 MatterIntakeScreen controllerClass = new MatterIntakeScreen(new ApexPages.StandardController(c));
 controllerClass.setRecordTypes('Litigation');
 controllerClass.getRecordTypes();
 controllerClass.saveMatter();
 Test.stopTest();
 system.assertEquals(controllerClass.getRecordTypes(), 'Litigation');

public class MatterIntakeScreen

public advpm__Matter__c matter get; set;
public String errorMessage get; set;

Case cs;

public MatterIntakeScreen(ApexPages.StandardController sc)
 cs = (Case)sc.getRecord();
 cs = [SELECT Id, Status, AccountId, Account.Name, Account.Legal_Status__c, Legal_Name__c,RecordType.Name, 
 Merchant_Number__c, Funded_Amount__c, Address__c, Fund_Date__c, Opportunity__c, Type, LP_Loan__c 
 FROM Case WHERE Id =: cs.Id];
 errorMessage = null;
 if(cs.Status == 'Closed')
 errorMessage = 'Case is already Closed.';
 cs.addError(errorMessage);
 
 matter = new advpm__Matter__c();


private boolean formIsValid() 
 boolean isValid = true;
 if (cs.Status == 'Closed') 
 cs.addError('Case is already Closed.');
 isValid = false;
 return isValid;
 

 List<RecordType> recordTypeList = [SELECT Id, Name FROM RecordType WHERE Id = :recordTypes];
 if(recordTypeList.size() > 0 )
 return isValid;


public PageReference saveMatter()
 Savepoint sp = Database.setSavepoint();

 try
 if (formIsValid() == false)
 return null;
 
 cs.Status = 'Closed';
 update cs;
 matter.advpm__Primary_Account__c = cs.AccountId;

 if(cs.RecordType.Name.equals('Portfolio Management'))
 matter.advpm__Matter_Number__c = cs.Merchant_Number__c;
 
 matter.Loan_Amount__c = cs.Funded_Amount__c;
 matter.Address_of_borrower__c = cs.Address__c;
 matter.Date_of_Loan__c= cs.Fund_Date__c;
 matter.Case__c = cs.Id;
 matter.advpm__Opportunity__c = cs.Opportunity__c;
 matter.LP_Loan__c = cs.LP_Loan__c;
 if(recordTypes != null)
 matter.RecordTypeId = recordTypes;
 
 insert matter;
 system.debug('newly inserted matter:: ' + matter);
 ....
 
 catch (Exception ex) 
 System.debug('ex----'+ex);
 ApexPages.addMessages(ex); 
 Database.rollback(sp);
 return null;
 


String recordTypes;
public List<SelectOption> getItems() 
 List<SelectOption> options = new List<SelectOption>(6);
 for(RecordType rt : [Select Id, Name From RecordType Where SobjectType = 'advpm__Matter__c' AND Name != 'Enforcement' AND Name != 'Standard']) 
 if(rt.Name == 'Litigation') 
 options.set(0, new SelectOption(rt.Id, rt.Name));
 
 else if(rt.Name == 'Bankruptcy')
 options.set(1, new SelectOption(rt.Id, rt.Name));
 
 else if(rt.Name == 'Litigation - BK')
 options.set(2, new SelectOption(rt.Id, rt.Name));
 
 else if(rt.Name == 'Defense')
 options.set(3, new SelectOption(rt.Id, rt.Name));
 
 else if(rt.Name == 'Records Requests')
 options.set(4, new SelectOption(rt.Id, rt.Name));
 
 else 
 options.add(new SelectOption(rt.Id, rt.Name));
 
 
 return options;


public String getRecordTypes() 
 return recordTypes;


public void setRecordTypes(String recordTypes) 
 this.recordTypes = recordTypes;

As far as I can see, the issue seems to be on this line in your test class:

controllerClass.setRecordTypes('Litigation');

The query as I see in your MatterIntakeScreen#formIsValid(), is as:

List<RecordType> recordTypeList = [SELECT Id, Name FROM RecordType WHERE Id = :recordTypes];

where you are fetching details based on the Record Type Id.

If you have set the recordTypes as a String value, the query above will never return any value and thus your execution will not get into the flow.

Either of the places needs a change, either you pass an appropriate record type id to the query, or (better approach) you change your query to accept a record type name/developer name.

Based on the highlighting, the query to the RecordType object (table) didn't return any rows.

Using an object describe to get the record type and it's ID is a better solution here and will probably also solve your issue.

The reason for this is that if there are no records of this type in the org yet, the RecordType object won't have any data in it. A describe of the object on the other hand, will always return its record types even if you haven't created any records of that type yet.

Assuming the developer name of the Record Type is Litigation

Schema.DescribeSObjectResult d = advpm__Matter__c.sObjectType.getDescribe();
Map<String, Schema.RecordTypeInfo> rtInfoMap = d.getRecordTypeInfosByDeveloperName();
Id rtId = rtInfoMap.get('Litigation').getRecordTypeId();