mjhjmtu

I am trying to create output which keeps hostname,ssh protocol and root login information with bash script.

And I would like to do it with developing functions. I developed .sh but it does not work.

Where is the problem in this sh?

Server Version Red Hat 7

my expected output should be;

xyz|hostname|Protocol X|Root Access Denied

And I would like to start to output "xyz" in order to pars my out but.

 #!/bin/bash


 host()
 local tmpfile=$(mktemp)
 hostname > "$tmpfile"
 printf '%s' "$tmpfile"
 

 protocol() grep Protocol

 rootlogin() grep -i "PermitRootLogin yes" 

 }


 tmpfile=$( host )

 
 host "$tmpfile"
 protocol "$tmpfile"
 rootlogin "$tmpfile"
 > fonk.out

 rm -f "$tmpfile"

The poor indentation and layout of your script muddles the question, but the basic answer is

printf '%s|%s|%s|%sn' "$(field1)" "$(field2)" "$(field3") "$(field4)"

Refactored into this, and with indentation etc cleaned up, your script becomes

#!/bin/bash

host()
 hostname


protocol()
 # avoid useless use of cat; get rid of unused parameter
 # ... do you need sudo here too?
 grep Protocol /etc/ssh/sshd_config


rootlogin()
 # straighten out massive spaghetti pretzel; remove unused parameter
 # ... can you avoid sudo cat here?
 if sudo cat /etc/ssh/sshd_config 

printf '%s|%s|%s|%sn' "$1" "$(host)" "$(protocol)" "$(rootlogin)" >fonk.out 

The last line is somewhat speculative; your current script doesn't seem to print the first field at all, and it's not clear what it's supposed to contain.

This no longer uses a temporary file, but one antipattern in your attempt was to create the temp file in an unrelated function. When you really do need a temp file, it would probably be a good idea to create it separately, then use it as a parameter everywhere. Like

tmp=$(mktemp) || exit
# arrange for temp file to be removed in case of errors or signals, too
trap 'rm -f "$tmp"' EXIT
trap 'exit' ERROR HUP QUIT TRAP TERM

function1 "$tmp"
function2 "$tmp"
: etc