mjhjmtu

I need to create a script that I can bind to a keyboard shortcut.
The script opens an instance of mozilla if it is not open and if is it minimizes or maximises the window.
Kind of like drop down terminal.

The script is working when I open it from a desktop shortcut but if I open the script directly by clicking on it or macro it to a keyboard shortcut it doesn't work as expected. It only opens mozilla but doesn't minimize or maximize

#!/bin/bash

touch memory.txt
myvar="$( xdotool search Mozilla )"
status="$(grep [0-1] memory.txt)"
run=0

if [ $(grep -c [0-9] <<< $myvar) -gt 0 ]
then
 pwd
else
 (firefox &)
fi

if [ $status = 0 ]
then
 $(xdotool windowminimize $myvar)
 echo -n "1" > memory.txt
 run=1 
fi

if [ $status = 1 ] && [ $run -eq 0 ]
then
 $(wmctrl -ia $myvar)
 echo -n "0" > memory.txt
fi
exit

• What Desktop Environment are you using?


• How are you defining the keybinding? Through a script or gui or cli tool?

Regarding your script, be sure to define the FULL PATH of your script in the shortcut manager. Do not use ~ because it will not be interpreted by the graphical shell. Also, be sure to set the script to executable.

Here is a script that I use to accomplish the same thing you are after: (I use it for a different application, and so I changed the code below to represent "firefox" in order to match your question.)
Note: I am using GNOME 3.28.2 and xdotool 3.20160805.1

#!/bin/bash
wid=$(xdotool search --onlyvisible --name 'firefox')
if test "$wid" = "" ; then exec firefox &
fi
actual=$(xdotool getactivewindow)
if test $wid = $actual ; then xdotool windowminimize $wid
else xdotool windowactivate $wid
fi
##EOF