mjhjmtu

On ~/Desktop/a/ , I have files and folders with this pattern:

 500 photodir
 Photo 500.jpg
 1000 photodir
 Photo 1000.jpg

I would like to have the .jpgs moved into their folders:

 500 photodir/Photo 500.jpg
 1000 photodir/Photo 1000.jpg

This is the code so far:

!#/bin/bash/
for f in ~/Desktop/a/*.jpg
do
 base=“$f%Photo*”
 mv "$f" "$base/"
 mv "$sub/$f"* "$base/$sub/"
done

#!/bin/bash
cd ~/Desktop/a/
for f in *.jpg; do
 target_part="$f%.jpg"
 target="$target_part#Photo "
 mv "$f" "$target photodir"
done

Explanation

There are two parameter substitutions occurring here. Firstly, target_part="$f%.jpg" removes the trailing .jpg from the filename, then target="$target_part#Photo " removes the Photo (+ space) at the front.

Then, you merely move the file to the number plus photodir, i.e. mv "$f" "$target photodir".

Further information

There were a few things wrong with your script. Firstly, the shebang was wrong. Instead of !#, it should be #!.

Secondly, I'm not sure if just a typo, but the double quote should be with ", not “.

I'm also not sure why the * in your parameter substitution of $f%Photo*, nor what the variable $sub referred to (it was never assigned).

Finally, instead of using ~/Desktop/a/*.jpg for the loop, I preferred to cd directly into it, to allow easier parameter substitution.