Promise.all returning empty objects

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP












11















I'm trying to get multiple data objects from The Movie Database at once using Promise.all. After I loop through all the results of the fetch call, and use .json() on each bit of data, I tried to log it to the console. However, rather than an array of objects with data, I'm getting an array of Promises. Nested in the promises, I can see my data, but I'm clearly missing a step in order to have an array of data objects, instead of just Promises.



What am I missing here?



 //store movie API URLs into meaningful variables
const trending = `https://api.themoviedb.org/3/trending/all/day?api_key=$API_KEY`;
const topRated = `https://api.themoviedb.org/3/movie/top_rated?api_key=$API_KEY&language=en-US&page=1`;
const nowPlaying = `https://api.themoviedb.org/3/movie/now_playing?api_key=$API_KEY&language=en-US&page=1`;
const upcoming = `https://api.themoviedb.org/3/movie/upcoming?api_key=$API_KEY&language=en-US&page=1`;
//create an array of urls to fetch data from
const allMovieURLs = [trending, topRated, nowPlaying, upcoming];
const promiseURLs = allMovieURLs.map(url => fetch(url));
Promise.all(promiseURLs)
.then(responses => responses.map(url => url.json()))
.then(dataArr => console.log(dataArr));
};









share|improve this question

















  • 3





    It's not the problem, but that code makes two common mistakes that may hit you at some point. 1. You're not checking that the requests succeed. This is such a common error (in my view, an error in the fetch API) that I wrote it up on my anemic little blog. Check .ok on the responses. 2. You're not handling rejection of your Promise.all promise, and not passing it to something that will handle it. You need to either handle it or pass the promise on to something that will.

    – T.J. Crowder
    Feb 24 at 14:31











  • closely related: Why does .json() return a promise?

    – Bergi
    Feb 24 at 15:19






  • 1





    @T.J.Crowder This is an awesome addition to a problem I didn't even know I was having. Much appreciated!

    – WonkasWilly
    Feb 25 at 6:47















11















I'm trying to get multiple data objects from The Movie Database at once using Promise.all. After I loop through all the results of the fetch call, and use .json() on each bit of data, I tried to log it to the console. However, rather than an array of objects with data, I'm getting an array of Promises. Nested in the promises, I can see my data, but I'm clearly missing a step in order to have an array of data objects, instead of just Promises.



What am I missing here?



 //store movie API URLs into meaningful variables
const trending = `https://api.themoviedb.org/3/trending/all/day?api_key=$API_KEY`;
const topRated = `https://api.themoviedb.org/3/movie/top_rated?api_key=$API_KEY&language=en-US&page=1`;
const nowPlaying = `https://api.themoviedb.org/3/movie/now_playing?api_key=$API_KEY&language=en-US&page=1`;
const upcoming = `https://api.themoviedb.org/3/movie/upcoming?api_key=$API_KEY&language=en-US&page=1`;
//create an array of urls to fetch data from
const allMovieURLs = [trending, topRated, nowPlaying, upcoming];
const promiseURLs = allMovieURLs.map(url => fetch(url));
Promise.all(promiseURLs)
.then(responses => responses.map(url => url.json()))
.then(dataArr => console.log(dataArr));
};









share|improve this question

















  • 3





    It's not the problem, but that code makes two common mistakes that may hit you at some point. 1. You're not checking that the requests succeed. This is such a common error (in my view, an error in the fetch API) that I wrote it up on my anemic little blog. Check .ok on the responses. 2. You're not handling rejection of your Promise.all promise, and not passing it to something that will handle it. You need to either handle it or pass the promise on to something that will.

    – T.J. Crowder
    Feb 24 at 14:31











  • closely related: Why does .json() return a promise?

    – Bergi
    Feb 24 at 15:19






  • 1





    @T.J.Crowder This is an awesome addition to a problem I didn't even know I was having. Much appreciated!

    – WonkasWilly
    Feb 25 at 6:47













11












11








11


1






I'm trying to get multiple data objects from The Movie Database at once using Promise.all. After I loop through all the results of the fetch call, and use .json() on each bit of data, I tried to log it to the console. However, rather than an array of objects with data, I'm getting an array of Promises. Nested in the promises, I can see my data, but I'm clearly missing a step in order to have an array of data objects, instead of just Promises.



What am I missing here?



 //store movie API URLs into meaningful variables
const trending = `https://api.themoviedb.org/3/trending/all/day?api_key=$API_KEY`;
const topRated = `https://api.themoviedb.org/3/movie/top_rated?api_key=$API_KEY&language=en-US&page=1`;
const nowPlaying = `https://api.themoviedb.org/3/movie/now_playing?api_key=$API_KEY&language=en-US&page=1`;
const upcoming = `https://api.themoviedb.org/3/movie/upcoming?api_key=$API_KEY&language=en-US&page=1`;
//create an array of urls to fetch data from
const allMovieURLs = [trending, topRated, nowPlaying, upcoming];
const promiseURLs = allMovieURLs.map(url => fetch(url));
Promise.all(promiseURLs)
.then(responses => responses.map(url => url.json()))
.then(dataArr => console.log(dataArr));
};









share|improve this question














I'm trying to get multiple data objects from The Movie Database at once using Promise.all. After I loop through all the results of the fetch call, and use .json() on each bit of data, I tried to log it to the console. However, rather than an array of objects with data, I'm getting an array of Promises. Nested in the promises, I can see my data, but I'm clearly missing a step in order to have an array of data objects, instead of just Promises.



What am I missing here?



 //store movie API URLs into meaningful variables
const trending = `https://api.themoviedb.org/3/trending/all/day?api_key=$API_KEY`;
const topRated = `https://api.themoviedb.org/3/movie/top_rated?api_key=$API_KEY&language=en-US&page=1`;
const nowPlaying = `https://api.themoviedb.org/3/movie/now_playing?api_key=$API_KEY&language=en-US&page=1`;
const upcoming = `https://api.themoviedb.org/3/movie/upcoming?api_key=$API_KEY&language=en-US&page=1`;
//create an array of urls to fetch data from
const allMovieURLs = [trending, topRated, nowPlaying, upcoming];
const promiseURLs = allMovieURLs.map(url => fetch(url));
Promise.all(promiseURLs)
.then(responses => responses.map(url => url.json()))
.then(dataArr => console.log(dataArr));
};






javascript






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Feb 24 at 9:15









WonkasWillyWonkasWilly

253211




253211







  • 3





    It's not the problem, but that code makes two common mistakes that may hit you at some point. 1. You're not checking that the requests succeed. This is such a common error (in my view, an error in the fetch API) that I wrote it up on my anemic little blog. Check .ok on the responses. 2. You're not handling rejection of your Promise.all promise, and not passing it to something that will handle it. You need to either handle it or pass the promise on to something that will.

    – T.J. Crowder
    Feb 24 at 14:31











  • closely related: Why does .json() return a promise?

    – Bergi
    Feb 24 at 15:19






  • 1





    @T.J.Crowder This is an awesome addition to a problem I didn't even know I was having. Much appreciated!

    – WonkasWilly
    Feb 25 at 6:47












  • 3





    It's not the problem, but that code makes two common mistakes that may hit you at some point. 1. You're not checking that the requests succeed. This is such a common error (in my view, an error in the fetch API) that I wrote it up on my anemic little blog. Check .ok on the responses. 2. You're not handling rejection of your Promise.all promise, and not passing it to something that will handle it. You need to either handle it or pass the promise on to something that will.

    – T.J. Crowder
    Feb 24 at 14:31











  • closely related: Why does .json() return a promise?

    – Bergi
    Feb 24 at 15:19






  • 1





    @T.J.Crowder This is an awesome addition to a problem I didn't even know I was having. Much appreciated!

    – WonkasWilly
    Feb 25 at 6:47







3




3





It's not the problem, but that code makes two common mistakes that may hit you at some point. 1. You're not checking that the requests succeed. This is such a common error (in my view, an error in the fetch API) that I wrote it up on my anemic little blog. Check .ok on the responses. 2. You're not handling rejection of your Promise.all promise, and not passing it to something that will handle it. You need to either handle it or pass the promise on to something that will.

– T.J. Crowder
Feb 24 at 14:31





It's not the problem, but that code makes two common mistakes that may hit you at some point. 1. You're not checking that the requests succeed. This is such a common error (in my view, an error in the fetch API) that I wrote it up on my anemic little blog. Check .ok on the responses. 2. You're not handling rejection of your Promise.all promise, and not passing it to something that will handle it. You need to either handle it or pass the promise on to something that will.

– T.J. Crowder
Feb 24 at 14:31













closely related: Why does .json() return a promise?

– Bergi
Feb 24 at 15:19





closely related: Why does .json() return a promise?

– Bergi
Feb 24 at 15:19




1




1





@T.J.Crowder This is an awesome addition to a problem I didn't even know I was having. Much appreciated!

– WonkasWilly
Feb 25 at 6:47





@T.J.Crowder This is an awesome addition to a problem I didn't even know I was having. Much appreciated!

– WonkasWilly
Feb 25 at 6:47












2 Answers
2






active

oldest

votes


















18














Your .then(responses => responses.map(url => url.json())) resolves to an array of Promises, so you need to call Promise.all again if you want to wait for all to resolve:



Promise.all(promiseURLs)
.then(responses => Promise.all(responses.map(url => url.json())))
.then(dataArr => console.log(dataArr));


Or, you might consider using just one Promise.all, and having each URL fetch and the json, that way some items aren't idle in the middle of script execution:



const allMovieURLs = [trending, topRated, nowPlaying, upcoming];
const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
Promise.all(promiseURLs)
.then(dataArr => console.log(dataArr));





share|improve this answer























  • I didn't realize that Body.json also returned a Promise! Your explanation was simple and concise, and this has solved my problem. Thank you.

    – WonkasWilly
    Feb 24 at 9:33






  • 1





    Probably worth pointing out the missing .ok check (I've done so now in a comment on the question).

    – T.J. Crowder
    Feb 24 at 14:32


















4














try doing it this way



const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
Promise.all(promiseURLs)
.then(responses => responses.forEach(response => console.log(response))





share|improve this answer






















    Your Answer






    StackExchange.ifUsing("editor", function ()
    StackExchange.using("externalEditor", function ()
    StackExchange.using("snippets", function ()
    StackExchange.snippets.init();
    );
    );
    , "code-snippets");

    StackExchange.ready(function()
    var channelOptions =
    tags: "".split(" "),
    id: "1"
    ;
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function()
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled)
    StackExchange.using("snippets", function()
    createEditor();
    );

    else
    createEditor();

    );

    function createEditor()
    StackExchange.prepareEditor(
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader:
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    ,
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    );



    );













    draft saved

    draft discarded


















    StackExchange.ready(
    function ()
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54850431%2fpromise-all-returning-empty-objects%23new-answer', 'question_page');

    );

    Post as a guest















    Required, but never shown

























    2 Answers
    2






    active

    oldest

    votes








    2 Answers
    2






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    18














    Your .then(responses => responses.map(url => url.json())) resolves to an array of Promises, so you need to call Promise.all again if you want to wait for all to resolve:



    Promise.all(promiseURLs)
    .then(responses => Promise.all(responses.map(url => url.json())))
    .then(dataArr => console.log(dataArr));


    Or, you might consider using just one Promise.all, and having each URL fetch and the json, that way some items aren't idle in the middle of script execution:



    const allMovieURLs = [trending, topRated, nowPlaying, upcoming];
    const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
    Promise.all(promiseURLs)
    .then(dataArr => console.log(dataArr));





    share|improve this answer























    • I didn't realize that Body.json also returned a Promise! Your explanation was simple and concise, and this has solved my problem. Thank you.

      – WonkasWilly
      Feb 24 at 9:33






    • 1





      Probably worth pointing out the missing .ok check (I've done so now in a comment on the question).

      – T.J. Crowder
      Feb 24 at 14:32















    18














    Your .then(responses => responses.map(url => url.json())) resolves to an array of Promises, so you need to call Promise.all again if you want to wait for all to resolve:



    Promise.all(promiseURLs)
    .then(responses => Promise.all(responses.map(url => url.json())))
    .then(dataArr => console.log(dataArr));


    Or, you might consider using just one Promise.all, and having each URL fetch and the json, that way some items aren't idle in the middle of script execution:



    const allMovieURLs = [trending, topRated, nowPlaying, upcoming];
    const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
    Promise.all(promiseURLs)
    .then(dataArr => console.log(dataArr));





    share|improve this answer























    • I didn't realize that Body.json also returned a Promise! Your explanation was simple and concise, and this has solved my problem. Thank you.

      – WonkasWilly
      Feb 24 at 9:33






    • 1





      Probably worth pointing out the missing .ok check (I've done so now in a comment on the question).

      – T.J. Crowder
      Feb 24 at 14:32













    18












    18








    18







    Your .then(responses => responses.map(url => url.json())) resolves to an array of Promises, so you need to call Promise.all again if you want to wait for all to resolve:



    Promise.all(promiseURLs)
    .then(responses => Promise.all(responses.map(url => url.json())))
    .then(dataArr => console.log(dataArr));


    Or, you might consider using just one Promise.all, and having each URL fetch and the json, that way some items aren't idle in the middle of script execution:



    const allMovieURLs = [trending, topRated, nowPlaying, upcoming];
    const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
    Promise.all(promiseURLs)
    .then(dataArr => console.log(dataArr));





    share|improve this answer













    Your .then(responses => responses.map(url => url.json())) resolves to an array of Promises, so you need to call Promise.all again if you want to wait for all to resolve:



    Promise.all(promiseURLs)
    .then(responses => Promise.all(responses.map(url => url.json())))
    .then(dataArr => console.log(dataArr));


    Or, you might consider using just one Promise.all, and having each URL fetch and the json, that way some items aren't idle in the middle of script execution:



    const allMovieURLs = [trending, topRated, nowPlaying, upcoming];
    const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
    Promise.all(promiseURLs)
    .then(dataArr => console.log(dataArr));






    share|improve this answer












    share|improve this answer



    share|improve this answer










    answered Feb 24 at 9:17









    CertainPerformanceCertainPerformance

    94.6k165685




    94.6k165685












    • I didn't realize that Body.json also returned a Promise! Your explanation was simple and concise, and this has solved my problem. Thank you.

      – WonkasWilly
      Feb 24 at 9:33






    • 1





      Probably worth pointing out the missing .ok check (I've done so now in a comment on the question).

      – T.J. Crowder
      Feb 24 at 14:32

















    • I didn't realize that Body.json also returned a Promise! Your explanation was simple and concise, and this has solved my problem. Thank you.

      – WonkasWilly
      Feb 24 at 9:33






    • 1





      Probably worth pointing out the missing .ok check (I've done so now in a comment on the question).

      – T.J. Crowder
      Feb 24 at 14:32
















    I didn't realize that Body.json also returned a Promise! Your explanation was simple and concise, and this has solved my problem. Thank you.

    – WonkasWilly
    Feb 24 at 9:33





    I didn't realize that Body.json also returned a Promise! Your explanation was simple and concise, and this has solved my problem. Thank you.

    – WonkasWilly
    Feb 24 at 9:33




    1




    1





    Probably worth pointing out the missing .ok check (I've done so now in a comment on the question).

    – T.J. Crowder
    Feb 24 at 14:32





    Probably worth pointing out the missing .ok check (I've done so now in a comment on the question).

    – T.J. Crowder
    Feb 24 at 14:32













    4














    try doing it this way



    const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
    Promise.all(promiseURLs)
    .then(responses => responses.forEach(response => console.log(response))





    share|improve this answer



























      4














      try doing it this way



      const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
      Promise.all(promiseURLs)
      .then(responses => responses.forEach(response => console.log(response))





      share|improve this answer

























        4












        4








        4







        try doing it this way



        const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
        Promise.all(promiseURLs)
        .then(responses => responses.forEach(response => console.log(response))





        share|improve this answer













        try doing it this way



        const promiseURLs = allMovieURLs.map(url => fetch(url).then(res => res.json()));
        Promise.all(promiseURLs)
        .then(responses => responses.forEach(response => console.log(response))






        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Feb 24 at 9:20









        George.SGeorge.S

        1166




        1166



























            draft saved

            draft discarded
















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid


            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.

            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54850431%2fpromise-all-returning-empty-objects%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown






            Popular posts from this blog

            How to check contact read email or not when send email to Individual?

            Bahrain

            Postfix configuration issue with fips on centos 7; mailgun relay