mjhjmtu

I'm afraid just about everybody who read this question has misunderstood it. I'm not trying to find the best way of printing a vector. I'm trying to find the best way of excluding part of an operation from the last iteration in a loop. I'm seeking advice about a pattern that is repeated is many different contexts. For this reason, I cannot provide a concrete example.

This question is off-topic

A well-formed comma-separated list has commas after all but the last element. This means that when dealing with these lists, the comma has to be dealt with on all but the last iteration. This is how I do things currently:

for (auto e = vec.cbegin(); e != vec.cend(); ++e) 
 // code that has to be executed for every element
 std::cout << *e;
 if (e != vec.cend() - 1) 
 // code that must not be executed for the last element
 std::cout << ", ";
 

There are five instances of the above pattern in the project that I'm working on. I feel like there might be a more elegant way of doing this. An alternative that I've come up with is this:

// infinite loop if vec is empty
if (!vec.empty()) 
 for (auto e = vec.cbegin(); e != vec.cend() - 1; ++e) 
 // code that has to be executed for every element
 std::cout << *e;
 // code that must not be executed for the last element
 std::cout << ", ";
 
 // code that has to be executed for every element
 std::cout << vec.back();

This alternative is slightly faster because there isn't an if in the body but that's not a big deal. The if is true for all but the last iteration so the branch predictor will probably only miss on the last iteration. I also have to repeat code that has to be executed for every element which means that I need to hoist that into a function.

The first snippet is the best that I can come up with but I feel like this could be done better. Note that writing to std::cout is just an example.

If you are just doing a single-shot printing of a container, just print the first element and then print delim-value pairs. This reduces the iterator requirements to being equality comparable, dereferenceable, and incrementable.

if (!vec.empty()) // invert to return immediately if this is a function
 auto first = vec.cbegin();
 std::cout << *first;

 while (vec.cend() != ++first) 
 std::cout << ", " << *first;
 

There is also a stateful approach that reduces the operation strength from branching on whether to print the delimiter to a pointer assignment.

auto actual_delim = ", ";
auto delim = "";

for (const auto& elem : vec) 
 std::cout << delim << elem;
 delim = actual_delim;

See infix_iterator where this stateful approach is used.

I'm not sure that elegance should be your first concern here, because the algorithm should be very simple and the code short however you write them.

I/O operations will have a much greater impact on performance than the lay-out of your loop, so you shouldn't worry too much about speed either.

Generality, I believe, is paramount in this case. That's why I see vec.cend() - 1 as the main short-coming of your proposal, because it restricts your algorithm to at least bidirectional iterators, when your goal can be easily achieved for any kind of iterator.

Here's what I would consider better:

#include <iostream>
#include <vector>

template <typename Container, typename Separator> // any container is acceptable...
void pretty_print(const Container& c, const Separator& s) 
 std::cout << '';
 auto it = std::begin(c); // ... even arrays
 if (it != std::end(c)) do 
 std::cout << *it;
 if (++it == std::end(c)) break; // that way you don't need to decrement the iterator
 std::cout << s;
 while (true);
 std::cout << '';

I always just use an additional variable:

auto first= true;

for (auto const& x : list) 
 if (first) first = false; else separator(x);
 action(x);

In your case, separator(x) would be std::cout << ", " (x isn’t actually used), and action(x) would be std::cout << x.

I normally abhor mutating variables inside a loop and try to use standard library algorithms on lambdas without side-effects instead. But in this case I believe having an additional boolean flag is simply the most economical, most readable solution.

This is also one of the very few cases (the only?) where I’m using a single-line if…else.

The advantage of this method is that you don’t have to duplicate action(x). Even if it’s just a single, simple expression, having such a duplication makes the logic disjointed and harder to follow.

The disadvantage is that the condition first has to be checked on every loop iteration. My suspicion is that the CPU’s branch predictor will handle this extremely well so it shouldn’t impact performance. Still, it’s conceptually irksome.

We are getting closer to the off-topic "opinion-based" border

What's readable is a matter of taste. Honestly, i find the @papafaga version less fluent.
You also have the possibility to do the opposite of your second version, to put the particular case before the loop, I do it sometimes when the case is trivial.

template <typename Container, typename Separator>
void pretty_print4(const Container& c, const Separator& s) 
 if (c.empty()) return;

 auto it = std::begin(c); 
 std::cout << *it;
 std::advance(it,1);
 while (it != std::end(c)) 
 std::cout << s;
 std::cout << *it;
 std::advance(it,1);
 

If you talk about performance, I think all versions are worth. Without optimizations, some versions generate more instructions than others, but once in -O3, except one or two instructions, it's almost the same. After, if it really matters, you have to look at the machine code and benchmark.

I tried this:

#include <iostream>
#include <iterator>
#include <string>
#include <vector>

template <typename Iterator, typename Char>
std::ostream& write_delim(std::ostream& out, Iterator iter, Iterator end, Char delim)

 if (iter != end) 
 out << *iter++;
 
 for (; iter != end; ++iter) 
 out << delim << *iter;
 
 return out;


int main(int argc, char** argv)

 int result = 0;

 typedef std::vector<std::string> string_collection;

 string_collection strings;
 strings.push_back("alpha");
 strings.push_back("beta");
 strings.push_back("kappa");
 strings.push_back("omega");

 write_delim(std::cout, strings.begin(), strings.end(), ',') << std::endl;
 write_delim(std::cout, strings.begin(), strings.end(), ", ") << std::endl;

 return result;

Output results:

alpha,beta,kappa,omega
alpha, beta, kappa, omega

For me, this:

1. Clearly communicates the point of the function, both in its name, and in how the code is written.


2. Is generic enough to be used in many situations... notice how I can use either a single character or multiple characters between the strings.


3. Works on older compilers.


4. Works whether you're writing to a file, console, string, or some customized output stream.

Refinements to this might better communicate errors if you chose the wrong type of delimiter for your output.