Does this function send ether from the contract or from the message sender?
Clash Royale CLAN TAG#URR8PPP
Solidity newbie here...:
function transfer(address payable to, address sender) public onlyadmin
to.transfer(msg.value);
what I want to achieve is sending from the contract's balance so I guess this.balance should be the correct way and not msg.value? Thanks!
solidity security
asked Jan 20 at 5:32
kpopguykpopguy
264
add a comment |
Solidity newbie here...:
function transfer(address payable to, address sender) public onlyadmin
to.transfer(msg.value);
what I want to achieve is sending from the contract's balance so I guess this.balance should be the correct way and not msg.value? Thanks!
solidity security
asked Jan 20 at 5:32
kpopguykpopguy
264
add a comment |
Solidity newbie here...:
function transfer(address payable to, address sender) public onlyadmin
to.transfer(msg.value);
what I want to achieve is sending from the contract's balance so I guess this.balance should be the correct way and not msg.value? Thanks!
solidity security
asked Jan 20 at 5:32
kpopguykpopguy
264
Solidity newbie here...:
function transfer(address payable to, address sender) public onlyadmin
to.transfer(msg.value);
what I want to achieve is sending from the contract's balance so I guess this.balance should be the correct way and not msg.value? Thanks!
solidity security
solidity security
asked Jan 20 at 5:32
kpopguykpopguy
264
asked Jan 20 at 5:32
kpopguykpopguy
264
asked Jan 20 at 5:32
kpopguykpopguy
264
asked Jan 20 at 5:32
kpopguykpopguy
264
asked Jan 20 at 5:32
kpopguykpopguy
264
264
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.
msg.value is the amount of Ether send along with the message.
If you want to send all money of the contract you have to write something like that:
function f(address payable beneficiary) public
beneficiary.transfer(address(this).balance);
If you write something like that:
function f(address payable beneficiary) payable public
beneficiary.transfer(msg.value);
Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.
answered Jan 20 at 6:47
BriomkezBriomkez
1,0201326
add a comment |
Your Answer
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "642"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fethereum.stackexchange.com%2fquestions%2f65824%2fdoes-this-function-send-ether-from-the-contract-or-from-the-message-sender%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.
msg.value is the amount of Ether send along with the message.
If you want to send all money of the contract you have to write something like that:
function f(address payable beneficiary) public
beneficiary.transfer(address(this).balance);
If you write something like that:
function f(address payable beneficiary) payable public
beneficiary.transfer(msg.value);
Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.
answered Jan 20 at 6:47
BriomkezBriomkez
1,0201326
add a comment |
Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.
msg.value is the amount of Ether send along with the message.
If you want to send all money of the contract you have to write something like that:
function f(address payable beneficiary) public
beneficiary.transfer(address(this).balance);
If you write something like that:
function f(address payable beneficiary) payable public
beneficiary.transfer(msg.value);
Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.
answered Jan 20 at 6:47
BriomkezBriomkez
1,0201326
add a comment |
Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.
msg.value is the amount of Ether send along with the message.
If you want to send all money of the contract you have to write something like that:
function f(address payable beneficiary) public
beneficiary.transfer(address(this).balance);
If you write something like that:
function f(address payable beneficiary) payable public
beneficiary.transfer(msg.value);
Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.
answered Jan 20 at 6:47
BriomkezBriomkez
1,0201326
Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.
msg.value is the amount of Ether send along with the message.
If you want to send all money of the contract you have to write something like that:
function f(address payable beneficiary) public
beneficiary.transfer(address(this).balance);
If you write something like that:
function f(address payable beneficiary) payable public
beneficiary.transfer(msg.value);
Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.
answered Jan 20 at 6:47
BriomkezBriomkez
1,0201326
edited Jan 20 at 9:21
answered Jan 20 at 6:47
BriomkezBriomkez
1,0201326
answered Jan 20 at 6:47
BriomkezBriomkez
1,0201326
answered Jan 20 at 6:47
BriomkezBriomkez
1,0201326
1,0201326
add a comment |
add a comment |
Thanks for contributing an answer to Ethereum Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fethereum.stackexchange.com%2fquestions%2f65824%2fdoes-this-function-send-ether-from-the-contract-or-from-the-message-sender%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown